[WIP]add candlestick chart in vchart-extension #4090
+903
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoluoHe
reviewed
Aug 13, 2025
| protected _getDefaultStyle() { | ||
| const defaultStyle: IMarkStyle<ICandlestickMarkSpec> = { | ||
| ...super._getDefaultStyle(), | ||
| boxWidth: 40 |
There was a problem hiding this comment.
[P0] boxWidth 根据 轴 bandwidth 计算，参考 boxplot，不能写死
xiaoluoHe
reviewed
Aug 13, 2025
| if (candlestickMark) { | ||
| const CandlestickStyles = { | ||
| boxWidth: this._boxWidth, | ||
| fill: this._boxFill ?? this.getCandlestickColorAttribute.bind(this), |
There was a problem hiding this comment.
[P1] 样式配置要生效在更多配置项；目前代码里只能生效在 fill/stroke
xuefei1313
reviewed
Aug 13, 2025
| 'closeField', | ||
| 'candlestickColor' | ||
| ]); | ||
| seriesSpec.yField = dataFields; |
There was a problem hiding this comment.
如果考虑不常见的水平方向的话，这里可以补充一个方向判定。相应的 interface 中也需要增加水平时的 yField 配置
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
🔗 Related PR link
🐞 Bugserver case id
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
copilot:summary
🔍 Walkthrough
copilot:walkthrough